core(gather): fix usesObjectFit property for ImageElement #6761
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It is bugfix.
There is good check Displays Images With Incorrect Aspect Ratio. However, this check is not needed when image has css property
object-fitdifferent thanfill. Valuescoverandcontainalready prevent this check. This PR makes valuesscale-downandnonealso prevent this check.Appropriate links:
https://developers.google.com/web/tools/lighthouse/audits/aspect-ratio
https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit
Related Issues/PRs
#6760